fix(emit): wrap no_mangle-family attrs as unsafe for edition-2024 round-trip#15
Open
jakobjung10 wants to merge 1 commit into
Open
fix(emit): wrap no_mangle-family attrs as unsafe for edition-2024 round-trip#15jakobjung10 wants to merge 1 commit into
jakobjung10 wants to merge 1 commit into
Conversation
…nd-trip When the generated crate is pretty-printed and recompiled at the 2024 edition, bare `#[no_mangle]` / `#[export_name]` / `#[link_section]` attributes are rejected. Macros expanded from earlier-edition dependencies can emit the bare form, which broke recompilation of the mutant crate. In the macro-expansion sanitizer, rewrite these attributes to the `#[unsafe(...)]` form when the session edition is 2024 or later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the generated crate is pretty-printed and recompiled at the 2024 edition, bare
#[no_mangle]/#[export_name]/#[link_section]attributes are rejected. Macros expanded from earlier-edition dependencies can emit the bare form, which broke recompilation of the mutant crate.In the macro-expansion sanitizer, rewrite these attributes to the
#[unsafe(...)]form when the edition is 2024 or later.